Fix Warnings in Docker Compose #3120
Open
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please review the changes? cc: @severo |
|
Could you please review the changes? cc: @lhoestq |
1 similar comment
|
Could you please review the changes? cc: @lhoestq |
|
hi ! why adding CACHED_ASSETS_BASE_URL and ASSETS_BASE_URL ? they have default values that are fine in the python codebase directly. The default for API_HF_JWT_PUBLIC_KEY_URL and API_HF_JWT_ADDITIONAL_PUBLIC_KEYS as blank are fine |
lhoestq
reviewed
Jan 13, 2025
|
Could you please review the changes? cc: @lhoestq |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the Makefiles for docker compose to fix the warnings described in #2289
I also had a query: What environment variable references do I have to set for CACHED_ASSETS_BASE_URL, API_HF_JWT_ADDITIONAL_PUBLIC_KEYS and ASSETS_BASE_URL since there were several different ones used. Please let me know and I will make the necessary changes.
Fixes #2289
cc: @severo